fix: the ASCII whitespaces are preserved so can not be escaped#1632
Closed
JounQin wants to merge 3 commits into
Closed
fix: the ASCII whitespaces are preserved so can not be escaped#1632JounQin wants to merge 3 commits into
JounQin wants to merge 3 commits into
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1632 +/- ##
==========================================
+ Coverage 96.15% 96.28% +0.12%
==========================================
Files 10 10
Lines 1196 1210 +14
Branches 461 465 +4
==========================================
+ Hits 1150 1165 +15
- Misses 37 40 +3
+ Partials 9 5 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f38ba36 to
cdb15b0
Compare
JounQin
commented
May 2, 2025
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Looks good for, will wait your answer before merge
alexander-akait
approved these changes
May 15, 2025
Member
Author
|
@alexander-akait @snitin315 Any ETA to merge and release? |
Member
|
@JounQin this week |
Member
Author
|
Friendly ping @alexander-akait @snitin315 @ersachin3112 |
Member
Author
|
@alexander-akait Hi, why this PR is closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
close #1626
Breaking Changes
N/A
Additional Info
related https://infra.spec.whatwg.org/#ascii-whitespace
cc @alexander-akait